refactor(neon_framework): rename credentials password to appPassowrd #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
refactor/neon_framework/rewrite_login_flow
to
main
September 13, 2024 03:26
provokateurin
requested changes
Sep 13, 2024
packages/neon_framework/packages/account_repository/lib/src/account_repository.dart
Outdated
Show resolved
Hide resolved
packages/neon_framework/packages/talk_app/lib/src/blocs/room.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolas Rimikis <[email protected]>
…dentials Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
refactor/neon_framework/rename_credential_parameters
branch
from
ff5ce04
to
5addca0
Compare
|
I just dropped the login name change and will fix that in the UserDetails bloc refactor. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
==========================================
- Coverage 30.29% 30.26% -0.03%
==========================================
Files 352 352
Lines 124389 124320 -69
==========================================
- Hits 37680 37631 -49
+ Misses 86709 86689 -20
*This pull request uses carry forward flags. Click here to find out more.
|
provokateurin
approved these changes
Sep 15, 2024
Leptopoda
deleted the
refactor/neon_framework/rename_credential_parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the initial account_repository PR (#2403 (comment)).